Revert "Move everything from lodash to lodash-es" #2591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC #2570 |
Codecov Report
@@ Coverage Diff @@
## master #2591 +/- ##
==========================================
+ Coverage 32.67% 95% +62.32%
==========================================
Files 398 6 -392
Lines 8842 40 -8802
Branches 954 2 -952
==========================================
- Hits 2889 38 -2851
+ Misses 5311 1 -5310
+ Partials 642 1 -641Continue to review full report at Codecov.
|
igor-dv
added
the
patch:yes
Hypnosphi
approved these changes
Dec 28, 2017
Hypnosphi
removed
the
patch:yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2558
Since
lodash-esrequires an extra configuration in the users' jest.config - it makes it a breaking change. Sadly I can't find a quick workaround, so have to revert it. This revert will return the problem of the wholelodashpackage being bundled to the angular app, and will need to be addressed separately.💔